Michal Kazior <michal.kazior@xxxxxxxxx> writes:
> This allows dynamic changes of bandwidth/nss/smps,
> e.g. via ht/vht operation mode change
> notification.
>
> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx>
[...]
> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -228,6 +228,17 @@ struct ath10k_peer {
> struct ieee80211_key_conf *keys[WMI_MAX_KEY_INDEX + 1];
> };
>
> +struct ath10k_sta {
> + struct ath10k_vif *arvif;
> +
> + u32 changed; /* IEEE80211_RC_* */
> + u32 bw;
> + u32 nss;
> + u32 smps;
> +
> + struct work_struct update_wk;
> +};
Apparently this structure is protected with data_lock, but it would be
good to document that in the code to make it clear.
> +static void ath10k_sta_rc_update(struct ieee80211_hw *hw,
> + struct ieee80211_vif *vif,
> + struct ieee80211_sta *sta,
> + u32 changed)
> +{
> + struct ath10k *ar = hw->priv;
> + struct ath10k_sta *arsta = (struct ath10k_sta *)sta->drv_priv;
> + u32 bw, smps;
> +
> + spin_lock_bh(&ar->data_lock);
> +
> + if (changed & IEEE80211_RC_BW_CHANGED) {
> + bw = WMI_PEER_CHWIDTH_20MHZ;
> +
> + switch (sta->bandwidth) {
> + case IEEE80211_STA_RX_BW_20:
> + bw = WMI_PEER_CHWIDTH_20MHZ;
> + break;
> + case IEEE80211_STA_RX_BW_40:
> + bw = WMI_PEER_CHWIDTH_40MHZ;
> + break;
> + case IEEE80211_STA_RX_BW_80:
> + bw = WMI_PEER_CHWIDTH_80MHZ;
> + break;
> + case IEEE80211_STA_RX_BW_160:
> + ath10k_warn("unsupported STA BW: %d\n", sta->bandwidth);
> + bw = WMI_PEER_CHWIDTH_20MHZ;
> + break;
I think it would be also useful to print STA's address in the warning.
> + if (changed & IEEE80211_RC_SMPS_CHANGED) {
> + smps = WMI_PEER_SMPS_PS_NONE;
> +
> + switch (sta->smps_mode) {
> + case IEEE80211_SMPS_AUTOMATIC:
> + case IEEE80211_SMPS_OFF:
> + smps = WMI_PEER_SMPS_PS_NONE;
> + break;
> + case IEEE80211_SMPS_STATIC:
> + smps = WMI_PEER_SMPS_STATIC;
> + break;
> + case IEEE80211_SMPS_DYNAMIC:
> + smps = WMI_PEER_SMPS_DYNAMIC;
> + break;
> + case IEEE80211_SMPS_NUM_MODES:
> + ath10k_warn("invalid smps mode: %d\n", sta->smps_mode);
> + smps = WMI_PEER_SMPS_PS_NONE;
> + break;
Maybe here as well?
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
