On 02/12/2014 04:04 PM, Stanislaw Gruszka wrote: > On Wed, Feb 12, 2014 at 12:27:05PM +0000, Grumbach, Emmanuel wrote: >>> I think we can keep IWL_DISABLE_HT_ALL option. I should be possible to >>> make some per-device type default settings and if disable_11n == 0 use >>> them. Otherwise use settings from module parameter. Will that work ? >> >> I'd prefer to have the default based on the iwldvm vs. iwlmvm instead of adding yet another per-HW field. But yeah - it is possible. > > I re-think changing default settings do disable TX AGG and must tell > that this is very odd. I would prefer to stay defaults as they are now. > Users can disable TX aggregation using module option. I disagree. We have bugs there - it is pretty much obvious. I remember a tracing from 2.6.39 which was before the re-architecture I made in the driver with clear FW bugs. I don't remember what device though. This is why I want to disable this by default. You asked me to do this with a module parameter and not with a Kconfig option - I agreed. Now - if you want to ship with a different settings, you can... but we both know the risk. > > I also not sure if that is really a firmware bug, it is rather more > probable that TX aggregation worked pretty fine on 5100 and other older > devices, but some driver changes broke that. Frankly, I don't really remember that... I have to say that I might not have been in the business at that period... -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
