Search Linux Wireless

RE: [RFC] iwlwifi: refactor the TX / RX ampdu override

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Subject: Re: [RFC] iwlwifi: refactor the TX / RX ampdu override
> 
> On Wed, Feb 12, 2014 at 01:19:49PM +0200, Emmanuel Grumbach wrote:
> > Note that this modifies the module parameter values / string which
> > means that distro will need to update their *.conf file (if any).
> 
> Hmm, this is not something that I would like to do ...

I thought you didn't care - ok - I'll respin

> 
> > -#define IWL_DISABLE_HT_ALL	BIT(0)
> > -#define IWL_DISABLE_HT_TXAGG	BIT(1)
> > -#define IWL_DISABLE_HT_RXAGG	BIT(2)
> > -#define IWL_DISABLE_HT_ALL	BIT(1)
> > +#define IWL_DISABLE_HT_TXAGG	BIT(1)
> > +#define IWL_DISABLE_HT_RXAGG	BIT(1)
> > +#define IWL_ENABLE_HT_TXAGG	BIT(2)
> > +#define IWL_ENABLE_HT_RXAGG	BIT(3)
> 
> I think we can keep IWL_DISABLE_HT_ALL option. I should be possible to
> make some per-device type default settings and if disable_11n == 0 use
> them. Otherwise use settings from module parameter. Will that work ?

I'd prefer to have the default based on the iwldvm vs. iwlmvm instead of adding yet another per-HW field. But yeah - it is possible.

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux