Search Linux Wireless

Re: [PATCH v4] cfg80211: regulatory introduce maximum bandwidth calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31 January 2014 15:07, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> On Thu, 2014-01-30 at 09:52 +0100, Janusz Dziedzic wrote:
>
> I'll apply this, but I think we should think about this:
>
>> @@ -950,11 +1027,18 @@ static void handle_channel(struct wiphy *wiphy,
>
>> +     max_bandwidth_khz = freq_range->max_bandwidth_khz;
>> +     /* Check if auto calculation requested */
>> +     if (!max_bandwidth_khz) {
>> +             regd = reg_get_regdomain(wiphy);
>> +             max_bandwidth_khz = reg_get_max_bandwidth(regd, reg_rule);
>> +     }
>
> It seems rather odd to have to look up the regdomain here, when we
> actually came from a regdomain update originally. Or didn't we?
>
In the handle_channel() function we don't know regd.

reg_rule = freq_reg_info(wiphy, MHZ_TO_KHZ(chan->center_freq));

from handle_channel() also look up the regdomain.
So, I did the same.

BR
Janusz
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux