On 31 January 2014 14:51, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Wed, 2014-01-29 at 14:22 +0100, Michal Kazior wrote: >> It was possible to break interface combinations in >> the following way: >> >> combo 1: iftype = AP, num_ifaces = 2, num_chans = 2, >> combo 2: iftype = AP, num_ifaces = 1, num_chans = 1, radar = HT20 >> >> With the above interface combinations it was >> possible to: >> >> step 1. start AP on DFS channel by matching combo 2 >> step 2. start AP on non-DFS channel by matching combo 1 >> >> This was possible beacuse (step 2) did not consider >> if other interfaces require radar detection. >> >> The patch changes how cfg80211 tracks channels - >> instead of channel itself now a complete chandef >> is stored. > > Applied. > > Do you also want to take this a little further and actually check > compatibility when checking for channel availability in > cfg80211_can_use_iftype_chan()? Right now it only checks the channel, > but cfg80211_get_chan_state() should really not have a channel argument > but a chandef instead. I briefly looked at the issue and have seen challenges. Although I'm not actively implementing it I may end up doing it at some point. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
