On 10 January 2014 10:19, Chun-Yeow Yeoh <yeohchunyeow@xxxxxxxxx> wrote:
> Fix the MAC address of wmi_peer_stats so that it is
> printed correctly. This is tested and verified using
> firmware version 999.999.0.636.
>
> Based on the verification, maximum only 3 peer statistics including
> self STA able to be printed out.
>
> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@xxxxxxxxx>
> ---
> v2: offset the stats to ignore the first peer (Chun-Yeow)
>
> drivers/net/wireless/ath/ath10k/debug.c | 4 ++++
> drivers/net/wireless/ath/ath10k/wmi.h | 14 +++++++-------
> 2 files changed, 11 insertions(+), 7 deletions(-)
>
[...]
> @@ -2820,9 +2820,9 @@ struct wmi_vdev_stats {
> * TODO: add more stats
> */
> struct wmi_peer_stats {
> + __le32 peer_tx_rate; /* TBA */
> struct wmi_mac_addr peer_macaddr;
> __le32 peer_rssi;
> - __le32 peer_tx_rate;
> } __packed;
This looks wrong too. I've just checked it and it seems the
`wal_dbg_tx_stats` is out of date. It's missing a `__le32
stateless_tid_alloc_failure` that has been inserted at some point in
time in the firmware between `pdev_resets` and `phy_underrun`. You
should add this missing field instead of moving `peer_tx_rate`.
Unfortunately AP firmware has even more fields inserted in
`wmi_pdev_stats`. Making this work with both firmwares is a mess.
Michał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
