On Wed, 2014-01-08 at 16:26 +0100, Michal Kazior wrote:
> This refactors cfg80211_can_use_iftype_chan() so
> that it can process multi-interface combination
> changes.
>
> With this it will be possible to handle, e.g.
> multi-BSS channel switching.
This seems reasonable, though I'd say that this code:
> + for (i = 0; i < num_params; i++) {
> + if (WARN_ON(hweight32(params[i].radar_detect_width) > 1))
> + return -EINVAL;
> +
> + /* sanity check - make sure all wdevs in params[] are unique */
> + for (j = 0; j < num_params; j++)
> + if (WARN_ON(i != j && params[i].wdev == params[j].wdev))
> + return -EINVAL;
could then use some refactoring, e.g. by moving the inside of the loop
to another helper function.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
