Search Linux Wireless

Re: [PATCH v5] wl12xx: fix tx power setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2014-01-13 at 12:14 -0500, Alex Gal wrote:

> > This doesn't really make sense since the driver handles
> > IEEE80211_CONF_CHANGE_POWER. If there's something wrong with that, maybe
> > that should be fixed?

> The IEEE80211_CONF_CHANGE_POWER never reaches the driver since in
> /net/mac80211/main.c:ieee80211_hw_config:
> 
>     if (!local->use_chanctx)
>         changed |= ieee80211_hw_conf_chan(local);
>     else
>         changed &= ~(IEEE80211_CONF_CHANGE_CHANNEL |
>                  IEEE80211_CONF_CHANGE_POWER);
> 
> only the else statement is executed.

Oh, really? Ok. I didn't think that driver supported channel contexts.
In that case your patch is right but incomplete - you should remove the
CONF_CHANGE_POWER handling.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux