Search Linux Wireless

Re: [PATCH v5] wl12xx: fix tx power setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Mon, Jan 13, 2014 at 8:35 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Fri, 2014-01-10 at 15:21 -0500, Alex Gal wrote:
>> The driver ignores BSS_CHANGED_TXPOWER changes.
>> Fix this by calling ACX_TX_POWER when appropriate.
>
> This doesn't really make sense since the driver handles
> IEEE80211_CONF_CHANGE_POWER. If there's something wrong with that, maybe
> that should be fixed?
>
> You should be able to see this with the debugging stuff.

I tried debugging a bit more.

The IEEE80211_CONF_CHANGE_POWER never reaches the driver since in
/net/mac80211/main.c:ieee80211_hw_config:

    if (!local->use_chanctx)
        changed |= ieee80211_hw_conf_chan(local);
    else
        changed &= ~(IEEE80211_CONF_CHANGE_CHANNEL |
                 IEEE80211_CONF_CHANGE_POWER);

only the else statement is executed.

However, the BSS_CHANGED_TXPOWER gets sent to the driver so I thought,
incorrectly,
that would be the the fix.

This behavior happens in kernel 3.10 but I suspect the same to happen
in mainline, unfortunately, I cannot test it.

Please let me know how I can debug this further since I am not
familiar with this code.

Cheers,

Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux