On Fri, 2014-01-03 at 21:30 +0000, clanctot@xxxxxxxxxxxxxx wrote: > >> + } else > >> + params.mfp = NL80211_MFP_NO; > > Code style. > For the issue of code style, I am not sure what you mean here. I copied > this code from the nl80211_connect routine, which has similar processing > for a “use MFP” parameter. I tried to make the code I added be consistent > with this existing code. > > If you explain what needs to be changed to improve the code style, I will > make the changes. All branches should (now) have braces if one of them requires it. > Regarding your question about a feature flag, there is already a flag > that indicates that the driver implements the AP SME: > * @WIPHY_FLAG_HAVE_AP_SME: device integrates AP SME > Is this the type of flag you were referring to? Yes, but it seems to me that you need a flag in the nl80211 API indicating that the AP SME supports PMF in this way. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
