Johannes,
Thanks for your comments regarding these changes. See my responses below.
- Chet
> On Tue, 2013-12-10 at 14:11 -0800, Chet Lanctot wrote:
>> + if (info->attrs[NL80211_ATTR_USE_MFP]) {
>> + params.mfp = nla_get_u32(info->attrs[NL80211_ATTR_USE_MFP]); + if
(params.mfp != NL80211_MFP_REQUIRED &&
>> + params.mfp != NL80211_MFP_OPTIONAL &&
>> + params.mfp != NL80211_MFP_NO)
>> + return -EINVAL;
>> + } else
>> + params.mfp = NL80211_MFP_NO;
> Code style.
> Wouldn't a feature flag be needed?
> johannes
For the issue of code style, I am not sure what you mean here. I copied
this code from the nl80211_connect routine, which has similar processing
for a ?use MFP? parameter. I tried to make the code I added be consistent
with this existing code.
If you explain what needs to be changed to improve the code style, I will
make the changes.
Regarding your question about a feature flag, there is already a flag
that indicates that the driver implements the AP SME:
* @WIPHY_FLAG_HAVE_AP_SME: device integrates AP SME
Is this the type of flag you were referring to?
I am ready to respond to any follow-on comments you have for this section
of code.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
