Search Linux Wireless

Re: [PATCH] rndis_wlan: fix sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > --- everything.orig/drivers/net/wireless/rndis_wlan.c	2008-02-20 11:43:22.000000000 +0100
> > +++ everything/drivers/net/wireless/rndis_wlan.c	2008-02-20 11:45:35.000000000 +0100
> > @@ -228,9 +228,9 @@ struct NDIS_WLAN_BSSID_EX {
> >  	struct NDIS_802_11_SSID Ssid;
> >  	__le32 Privacy;
> >  	__le32 Rssi;
> > -	enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
> > +	__le32 NetworkTypeInUse;
> >  	struct NDIS_802_11_CONFIGURATION Configuration;
> > -	enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
> > +	__le32 InfrastructureMode;
> >  	u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
> >  	__le32 IELength;
> >  	u8 IEs[0];
> 
> This suggests that the values in the enum need to be explicitly
> defined, does it not?

Yeah, well, it is probably understood that those values are from
hardware. We don't always explicitly define them even when they are
defined elsewhere since afaik C guarantees starting at 0 and increasing
order.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux