On Wed, Feb 20, 2008 at 11:47:45AM +0100, Johannes Berg wrote:
> It is obviously wrong to use an enum in a little endian struct,
> and those other enums should be declared differently.
>
> Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> ---
> drivers/net/wireless/rndis_wlan.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> --- everything.orig/drivers/net/wireless/rndis_wlan.c 2008-02-20 11:43:22.000000000 +0100
> +++ everything/drivers/net/wireless/rndis_wlan.c 2008-02-20 11:45:35.000000000 +0100
> @@ -228,9 +228,9 @@ struct NDIS_WLAN_BSSID_EX {
> struct NDIS_802_11_SSID Ssid;
> __le32 Privacy;
> __le32 Rssi;
> - enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse;
> + __le32 NetworkTypeInUse;
> struct NDIS_802_11_CONFIGURATION Configuration;
> - enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
> + __le32 InfrastructureMode;
> u8 SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
> __le32 IELength;
> u8 IEs[0];
This suggests that the values in the enum need to be explicitly
defined, does it not?
--
John W. Linville
linville@xxxxxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
