Am Samstag, 19. Oktober 2013, 10:33:06 schrieb Gertjan van Wingerde: > On 10/18/13 11:42, Stanislaw Gruszka wrote: > > On Thu, Oct 17, 2013 at 09:39:06AM -0500, Larry Finger wrote: > >> I suggest getting rid of the magic numbers as long as you are making > >> this change. A single define could handle the delay time for the two > >> cases. > > > > Thanks for sugestion Larry, though I do not see clear benefit of > > introduce define since those magic numbers are just time values > > expressed in nano seconds. Anyway patch with define added below. > > John can pick it, if he thinks it is better. > > > > Stanislaw > > --- > > From 813e0bde7340bad7d3401c6aa2a3f8635ec49597 Mon Sep 17 00:00:00 2001 > > From: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> > > Date: Fri, 18 Oct 2013 11:36:54 +0200 > > Subject: [PATCH] rt2800usb: slow down TX status polling > > > > Polling TX statuses too frequently has two negative effects. First is > > randomly peek CPU usage, causing overall system functioning delays. > > Second bad effect is that device is not able to fill TX statuses in > > H/W register on some workloads and we get lot of timeouts like below: > > > > ieee80211 phy4: rt2800usb_entry_txstatus_timeout: Warning - TX status > > timeout for entry 7 in queue 2 ieee80211 phy4: > > rt2800usb_entry_txstatus_timeout: Warning - TX status timeout for entry 7 > > in queue 2 ieee80211 phy4: rt2800usb_txdone: Warning - Got TX status for > > an empty queue 2, dropping > > > > This not only cause flood of messages in dmesg, but also bad throughput, > > since rate scaling algorithm can not work optimally. > > > > In the future, we should probably make polling interval be adjusted > > automatically, but for now just increase values, this make mentioned > > problems gone. > > > > Resolve: > > https://bugzilla.kernel.org/show_bug.cgi?id=62781 > > > > Cc: stable@xxxxxxxxxxxxxxx > > Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> > > I don't care which version gets picked. In both cases: > > Acked-by: Gertjan van Wingerde <gwingerde@xxxxxxxxx> did this ever hit a stable queue? Marc -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
