Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> writes: >> I think we can use here spin_lock_bh(&ar->data_lock) when setting >> ar->debug.dfs_stats and when reading this from debugfs. >> But, is that really needed (in worst case we will get older values via debugfs)? > > I would prefer not to have any race conditions in the driver, even if > it's just statistics. If there's only a race with statistics atomic > variables are also one option. I took a new look at these statistics and I think you are right. It feels a bit overkill to use locking or atomic variables here. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
