On Mon, Nov 11, 2013 at 04:46:36PM +0100, Johannes Berg wrote: > On Mon, 2013-11-11 at 13:10 +0100, Karl Beldan wrote: > > From: Karl Beldan <karl.beldan@xxxxxxxxxxxxxxxx> > > > > ATM minstrel_ht does not check whether a sampling rate is supported. > > Unsupported rates attempts can trigger when there are holes in bitfields > > of supported MCSes belonging to the same group (e.g many devices are > > MCS32 capable without MCS33->39 capable, also we systematically have a > > hole for CCK rates). > > I originally replaced an unsupported sample index with the fls of the > > bitfield of supported indexes of the sta current sample group, instead, > > this change simply drops the sample attempt, as suggested by Felix. > > That paragraph doesn't really belong here - you should describe what > this change is doing (now). There may be some value in describing how > you arrived at the solution, but this particular description seems > unnecessary? > Feel free to get rid of the superfluous comments. Karl -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
