On Mon, Nov 11, 2013 at 04:45:45PM +0100, Johannes Berg wrote: > On Fri, 2013-11-08 at 17:34 +0100, Karl Beldan wrote: > > From: Karl Beldan <karl.beldan@xxxxxxxxxxxxxxxx> > > > > These are called to init the sample tables. > > This occurs once in minstrel_ht upon its registration (since it uses one > > single common sample table for all STAs), and once per sta addition in > > minstrel. > > This commit log is suboptimal, it doesn't even seem to describe a change > but rather the behaviour after (or before?) the change? > Other than replacing: "These are called to init the sample tables.\nThis occurs once in" with: "These are called to init the sample tables, which occurs once in", plus this ridiculously small diff in a non convoluted localized code path .. FYI, this lowers the prng bytes demands from about 10*12*8bytes to 10*8bytes per non-ht sta addition and at minstrel_ht init. This is to relate to the email posted just after I posted this change: http://marc.info/?l=linux-wireless&m=138393239432434&w=2 Karl -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html