Search Linux Wireless

Re: [Patch v2 1/3] net: wireless: replace printk with netdev_warn in adm8211.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2013-10-25 at 00:30 +0300, Georgiana Rodica Chelu wrote:
> WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(...
> to printk(KERN_WARNING ...

Hi Georgiana.

Please compile and test your patches before submitting them.

> diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c

> @@ -151,8 +151,9 @@ static int adm8211_read_eeprom(struct ieee80211_hw *dev)
>  		else
>  			priv->rf_type = ADM8211_TYPE_AIROHA;
>  
> -		printk(KERN_WARNING "%s (adm8211): Unknown RFtype %d\n",
> -		       pci_name(priv->pdev), (cr49 >> 3) & 0x7);
> +		netdev_warn(priv->pdev, "(adm8211): Unknown RFtype %d\n",
> +			    pci_name(priv->pdev), (cr49 >> 3) & 0x7);
> +
>  	}
>  
>  	priv->bbp_type = cr49 & 0x7;

netdev_warn 1st arg is a struct net_device *
priv->pdev is a struct pci_dev *


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux