Search Linux Wireless

Re: [PATCH 11/13] wlcore: memset wl->rx_filter_enabled to zero after recovery

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2013-09-09 at 12:24 +0300, Eliad Peller wrote:
> From: Nadim Zubidat <nadimz@xxxxxx>
> 
> zero rx_filter_enabled array after recovery to avoid
> cases were the driver will keep trying to clear a
> filter which is not configured in FW.
> 
> Such case will cause consecutive recoveries due to
> command execution failures.
> 
> Signed-off-by: Nadim Zubidat <nadimz@xxxxxx>
> Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx>
> ---
>  drivers/net/wireless/ti/wlcore/main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
> index 60b2113..acb3502 100644
> --- a/drivers/net/wireless/ti/wlcore/main.c
> +++ b/drivers/net/wireless/ti/wlcore/main.c
> @@ -1915,6 +1915,7 @@ static void wlcore_op_stop_locked(struct wl1271 *wl)
>  	memset(wl->links_map, 0, sizeof(wl->links_map));
>  	memset(wl->roc_map, 0, sizeof(wl->roc_map));
>  	memset(wl->session_ids, 0, sizeof(wl->session_ids));
> +	memset(wl->rx_filter_enabled, 0, sizeof(wl->rx_filter_enabled));
>  	wl->active_sta_count = 0;
>  	wl->active_link_count = 0;

This causes a sparse warning:

drivers/net/wireless/ti/wlcore/main.c:1918:42: error: cannot size expression

Booleans cannot be sized. :(

I won't apply this patch.

--
Luca.



--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux