Hi Helmut, > On Thu, Oct 17, 2013 at 9:42 AM, Gabor Juhos <juhosg@xxxxxxxxxxx> wrote: >> The rt2800pci driver supports both PCI and SoC device. To achieve >> this, the code uses several ifdef statements which makes the code >> quite ugly. The patch set introduces a shared module, and moves the >> SoC driver into a separate module to get rid of the mess. > > Nice series. Does this also reduce module size on when building for > SoC without PCI support? Nope. On the contrary, there is a small increase due to the new rt2800mmio module (compiled for RT305x SoCs): before: text data bss dec hex filename 7232 96 16 7344 1cb0 rt2800pci.o after: text data bss dec hex filename 1934 100 16 2050 802 rt2800soc.o 5664 0 0 5664 1620 rt2800mmio.o delta: +366 +4 0 +370 -Gabor -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html