Hi Dan, Thanks for your comments. Current patch is to report event asynchronously and that would be needed even if we have your suggested interface of client collecting that information upfront, which seems like you also kind of agree, because RF environment may change later and generating an event at that time with frequency details would help. So your suggested approach of "mechanism for the client to get this information" in itself seems like a candidate for a separate patch. On the race condition which you described - thanks!, but it is something which implementation of driver would need to take care. Similarly, user space can have implementation to cache information on receipt of the event to use it later. Regards, Rajesh Chauhan -----Original Message----- From: Dan Williams [mailto:dcbw@xxxxxxxxxx] Sent: Thursday, October 17, 2013 11:40 AM To: Chauhan, Rajesh Cc: Johannes Berg; linux-wireless@xxxxxxxxxxxxxxx; Rodriguez, Luis; Malinen, Jouni; Bahini, Henri; Chang, Leo; Luo, Xun Subject: Re: [PATCH] cfg80211/nl80211: Add support to report unsafe frequency ranges(s) On Thu, 2013-10-17 at 17:46 +0000, Chauhan, Rajesh wrote: > Hi Johannes, > > Let me also replace SAP with SoftAP. > > So now commit text would be: > > cfg80211/nl80211: Add API to report frequency range(s) to be avoided > > Add support for WLAN driver to report frequency range(s) to be avoided because of interference. If SoftAP/P2P-GO is operating on interfering frequency then user space should stop and restart them avoiding interfering frequency range(s). User space may decide to continue operation on interfering frequency, but in such case, there might be impact on performance. Wouldn't a better interface be to: a) provide a list of undesirable frequencies at all times, instead of an event, so that userspace can decide *before* creating a Soft AP or P2P which is the best channel to use, if it wants. Possibly through the same mechanisms that it's other capabilities are exposed through (like the full list of supported frequencies, eg "iw phy phy0 info"). Driver can update this list at any time if it notices changes to the RF environment. b) if the current operating channel for some Soft AP or P2P interface becomes undesirable, emit an event indicating that this channel is undesirable. Userspace can then decide to continue operating on that channel, or it can check the list of "undesirable" channels from (a) and pick a different one, and move to it. This is essentially your current patch, but the event need not carry the channel list, since that's exposed by (a) already. There is a small race between a client reading (a) and a client creating the SoftAP/P2P interface, so it would also be useful that if the channel a client is creating the SoftAP/P2P on is undesirable the event gets emitted immediately after creation. My issue with the original patch is that it only defines the event, it doesn't define a mechanism for the client to get this information *before* doing the operation that may be undesirable. Dan > Regards, > Rajesh Chauhan > > > -----Original Message----- > From: Chauhan, Rajesh > Sent: Thursday, October 17, 2013 10:20 AM > To: 'Johannes Berg' > Cc: linux-wireless@xxxxxxxxxxxxxxx; Rodriguez, Luis; Malinen, Jouni; > Bahini, Henri; Chang, Leo; Luo, Xun; Chauhan, Rajesh > Subject: RE: [PATCH] cfg80211/nl80211: Add support to report unsafe > frequency ranges(s) > > Hi Johannes, > > Thanks for your comment. Purpose of this patch is to add an API for WLAN driver to report frequency ranges which should be avoided for SAP/P2P-GO because of interference. > > How about if I reword commit test as below? > > cfg80211/nl80211: Add API to report frequency range(s) to be avoided > > Add support for WLAN driver to report frequency range(s) to be avoided because of interference. If SAP/P2P-GO is operating on interfering frequency then user space should stop and restart them avoiding interfering frequency range(s). User space may decide to continue operation on interfering frequency, but in such case, there might be impact on performance. > > Regards, > Rajesh Chauhan > > > -----Original Message----- > From: Johannes Berg [mailto:johannes@xxxxxxxxxxxxxxxx] > Sent: Thursday, October 17, 2013 7:41 AM > To: Chauhan, Rajesh > Cc: linux-wireless@xxxxxxxxxxxxxxx; Rodriguez, Luis; Malinen, Jouni > Subject: Re: [PATCH] cfg80211/nl80211: Add support to report unsafe > frequency ranges(s) > > On Wed, 2013-10-16 at 21:57 -0700, Rajesh Chauhan wrote: > > Add support for WLAN driver to report unsafe frequency range(s). > > Why? > > > User > > space should move SAP/P2P-GO out of those unsafe frequency range(s). > > User space may decide to continue operation on unsafe frequency but > > in such case there might be impact on performance because of interference. > > SAP? I don't think SAP will move - they're pretty stuck in Walldorf :P > > This is pretty strange patch, and very little justification. > > "Unsafe" is also a really bad word. > > johannes > > NrybXǧv^){.n+{*ޕ,{ay ʇڙ,j fhz w j:+vwjm zZ+ݢj"! ��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
