Search Linux Wireless

Re: [PATCH] mac80211_hwsim: Add iface comb for DFS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2013-10-14 at 19:51 +0200, Janusz Dziedzic wrote:
> Add iface combination that allow DFS support.
> Add also debugfs dfs_simulate_radar file that
> can be used to simulate radar event.
> This could be usefull for mac80211/cfg80211/

typo: useful

> @@ -1714,6 +1716,7 @@ static void mac80211_hwsim_free(void)
>  
>  	list_for_each_entry_safe(data, tmpdata, &tmplist, list) {
>  		debugfs_remove(data->debugfs_group);
> +		debugfs_remove(data->debugfs_radar);

I think it would be good to convert to debugfs_remove_recursive first -
that avoids the need for the new dentry pointer as well as the remove
here. Can you do that (as a separate patch)?

> +static int hwsim_write_simulate_radar(void *dat, u64 val)
> +{
> +	struct mac80211_hwsim_data *data = dat;
> +
> +	ieee80211_radar_detected(data->hw);
> +
> +	return 0;
> +}
> +
> +DEFINE_SIMPLE_ATTRIBUTE(hwsim_simulate_radar, NULL,
> +			hwsim_write_simulate_radar, "%llu\n");

Does the u64 make sense? Probably doesn't matter much, but seems weird
to be so specific for a file that really doesn't care about the value?
 
johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux