On 15 October 2013 11:49, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: > Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> writes: > >> From: Michal Kazior <michal.kazior@xxxxxxxxx> >> >> mac80211 interface interations functions have >> peculiar locking issues. This patch introduces >> internal (to ath10k) vif list that will be used >> for vif iteration purposes. >> >> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx> >> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> > > [...] > >> --- a/drivers/net/wireless/ath/ath10k/core.c >> +++ b/drivers/net/wireless/ath/ath10k/core.c >> @@ -713,6 +713,7 @@ struct ath10k *ath10k_core_create(void *hif_priv, struct device *dev, >> mutex_init(&ar->conf_mutex); >> spin_lock_init(&ar->data_lock); >> >> + INIT_LIST_HEAD(&ar->arvifs); >> INIT_LIST_HEAD(&ar->peers); >> init_waitqueue_head(&ar->peer_mapping_wq); >> >> @@ -824,6 +825,7 @@ int ath10k_core_start(struct ath10k *ar) >> goto err_disconnect_htc; >> >> ar->free_vdev_map = (1 << TARGET_NUM_VDEVS) - 1; >> + INIT_LIST_HEAD(&ar->arvifs); >> >> return 0; > > Michal, why do the INIT_LIST_HEAD() twice? Isn't it enough to do it > core_start()? Ah, good point. It's most likely okay to just do it in ath10k_core_start(). The one in ath10k_core_create() isn't required. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
