On Sun, 2013-10-13 at 10:01 +0530, Mihir Shete wrote: > 802.11 cards may have different country IE parsing behavioural > preferences and vendors may want to support these. These preferences > were managed by the WIPHY_FLAG_CUSTOM_REGULATORY and the > WIPHY_FLAG_STRICT_REGULATORY flags and their combination. > Instead of using this existing notation, split out the country > IE behavioural preferences to a new flag. This will allow > us to add more customizations easily and make the code more > maintainable > regd = ath_world_regdomain(reg); > wiphy->flags |= WIPHY_FLAG_CUSTOM_REGULATORY; > + wiphy->country_ie_pref = NL80211_COUNTRY_IE_FOLLOW_POWER; That seems pretty weird - maybe you should have a first patch that moves the existing regulatory flags into some new field, and then adds the country IE flags there? Adding a new flags field for just the country IE seems odd and less useful for the future. > + * @country_ie_pref: country IE processing preferences specified > + * by enum nl80211_country_ie_pref That implies you're exporting it to userspace - why? > /** > + * enum nl80211_country_ie_pref - country IE processing preferences Why is this userspace API if it's not used anywhere as such? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
