On Mon, Oct 7, 2013 at 1:59 PM, Eugene Krasnikov <k.eugene.e@xxxxxxxxx> wrote: > Hi Luis, > > I looked at your patch deeper and couple of questions appeared: > > 1) The first line in the function ath_regd_init will execute > container_of with "struct ath_common". Do not you think we can try to > access wrong memory area? Good catch, can you add an ath_common to the general wcn data structure and then embed the reg under it? That'd fix that. > 2) __ath_regd_init will try to access EEPROM or at least call > functions with eeprom related. That's inherited from the language used on the HAL code. The HAL is no longer a HAL and we have general "hardware code". The code in that file is more than anything now just database specific information, as such routines like ath_regd_get_eepromRD() could be renamed to reflect they are simply accessing regulatory information from the card. > It's a bit misleading because > wcn36xx is not using eeprom. If possible could you please explain what > is the connection between ath regd implementation and EEPROM? Indeed, agreed. The way to properly use regulatory on the wcn driver will be parse the nvram and populate the struct ath_regulatory appropriately. This then makes the EEPROM verbiage inappropriate and do welcome such changes reflected on regd.c but don't see them required for wcn to use them. This can be made as further clarifications once the wcn driver gets merged. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
