Hi Luis, Thanx for the patch. Although there is a one small comment: > +static void wcn_reg_notifier(struct wiphy *wiphy, > + struct regulatory_request *request) > +{ Function should be called wcn36xx_reg_notifier not wcn_reg_notifier. Could you please change that? Also are you concerned about this warnings? > Nice! I test compiled with sparse enabled and got this: > > mcgrof@chalten ~/wireless-testing (git::master)$ make C=1 > M=drivers/net/wireless/ath/wcn36xx/ > CHECK drivers/net/wireless/ath/wcn36xx/main.c > CC [M] drivers/net/wireless/ath/wcn36xx/main.o > CHECK drivers/net/wireless/ath/wcn36xx/dxe.c > CC [M] drivers/net/wireless/ath/wcn36xx/dxe.o > CHECK drivers/net/wireless/ath/wcn36xx/txrx.c > CC [M] drivers/net/wireless/ath/wcn36xx/txrx.o > CHECK drivers/net/wireless/ath/wcn36xx/smd.c > /home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (4096 8) > /home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (512 8) > /home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (128 8) > /home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (8 8) > /home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (256 8) > /home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (4096 8) What kind of config are you using to generate this warnings? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html