On Wed, 2013-10-02 at 01:02 -0700, Chun-Yeow Yeoh wrote: > struct cfg80211_csa_settings { > struct cfg80211_chan_def chandef; > @@ -695,7 +697,9 @@ struct cfg80211_csa_settings { > struct cfg80211_beacon_data beacon_after; > bool radar_required; > bool block_tx; > + u8 mode; > u8 count; > + u8 ttl; > }; You certainly meant well to reuse the structs, but that doesn't make sense. This struct is used for the cfg80211/driver (cfg80211/mac80211) API, so adding these parameters to it makes no sense at all. It seems you'd need a new structure that's internal to mac80211 for the function argument. I'd also prefer to do the refactoring in a separate patch. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html