Search Linux Wireless

Re: [PATCH] mac80211: Extend filter flag documentation about unsupported flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> + * All unsupported flags in @total_flags must be cleared.
> + * Hardware does not support a flag if it is incapable of _passing_
> + * the frame to the stack. Otherwise it must simply ignore the flag,
> + * but not clear it.

I think mentioning the driver is important:

"Otherwise the driver must ignore the flag but not clear it."

> + * So for example, you should clear @FIF_CONTROL, if your hardware
> + * always filters control frames. If your hardware does always pass

s/does always pass/always passes/

Other than that,

Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>

so please add that when you resend.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux