> -----Original Message----- > From: Larry Finger [mailto:larry.finger@xxxxxxxxx] On Behalf Of Larry > Finger > Sent: Monday, September 16, 2013 9:40 PM > To: Emmanuel Grumbach > Cc: Seth Forshee; Jason Andrews; linux-wireless@xxxxxxxxxxxxxxx > Subject: Re: guidance on struct alignment for rtl8192cu driver > > On 09/16/2013 02:29 PM, Emmanuel Grumbach wrote: > >>>> Index: wireless-testing-save/drivers/net/wireless/rtlwifi/wifi.h > >>>> > =================================================================== > >>>> --- wireless-testing-save.orig/drivers/net/wireless/rtlwifi/wifi.h > >>>> +++ wireless-testing-save/drivers/net/wireless/rtlwifi/wifi.h > >>>> @@ -2057,7 +2057,7 @@ struct rtl_priv { > >>>> that it points to the data allocated > >>>> beyond this structure like: > >>>> rtl_pci_priv or rtl_usb_priv */ > >>>> - u8 priv[0]; > >>>> + u8 __aligned(4) priv[0]; > >>>> }; > >>> > >>> > >>> __attribute__((aligned)) might be a safer bet, as this will align > it to > >>> the largest alignment that could possibly be needed. > > > > Or copy the code from mac80211.h: > > > > u8 drv_priv[0] __aligned(sizeof(void *)); > > > > I did the same in iwlwifi. > > Note the new way to add the __aligned thing. Joe will tell you that > is > > better than __attribute__ blablabla > > Thanks. I had noticed that checkpatch.pl complains about the > __attribute > construction. > > Larry > Larry, I confirmed that my original alignment error is properly solved by: u8 drv_priv[0] __aligned(sizeof(void *)); The driver is now working for my ARM system. Regards, Jason -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
