On 28 August 2013 06:12, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote:
> Michal Kazior <michal.kazior@xxxxxxxxx> writes:
>
>> Simplifies memory managament of ce_state.
>>
>> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx>
>
> Sorry, I noticed this only in my second review round:
>
>> --- a/drivers/net/wireless/ath/ath10k/pci.h
>> +++ b/drivers/net/wireless/ath/ath10k/pci.h
>> @@ -233,7 +233,10 @@ struct ath10k_pci {
>> spinlock_t ce_lock;
>>
>> /* Map CE id to ce_state */
>> - struct ce_state *ce_id_to_state[CE_COUNT_MAX];
>> + struct ce_state ce_states[CE_COUNT_MAX];
>> +
>> + /* makes sure that dummy reads are atomic */
>> + spinlock_t hw_v1_workaround_lock;
>> };
>
> That lock doesn't look right. Is it a leftover from a rebase?
Oh, good catch. I wonder how it got there..
Michał.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
