Search Linux Wireless

Re: [PATCH v2 1/6] ath10k: use inline ce_state structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Michal Kazior <michal.kazior@xxxxxxxxx> writes:

> Simplifies memory managament of ce_state.
>
> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx>

Sorry, I noticed this only in my second review round:

> --- a/drivers/net/wireless/ath/ath10k/pci.h
> +++ b/drivers/net/wireless/ath/ath10k/pci.h
> @@ -233,7 +233,10 @@ struct ath10k_pci {
>  	spinlock_t ce_lock;
>  
>  	/* Map CE id to ce_state */
> -	struct ce_state *ce_id_to_state[CE_COUNT_MAX];
> +	struct ce_state ce_states[CE_COUNT_MAX];
> +
> +	/* makes sure that dummy reads are atomic */
> +	spinlock_t hw_v1_workaround_lock;
>  };

That lock doesn't look right. Is it a leftover from a rebase?

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux