On Monday, July 22, 2013 09:17:01 AM Luis R. Rodriguez wrote: > On Sun, Jul 21, 2013 at 10:06:31AM +0300, Vladimir Kondratiev wrote: > > Hmm, I have no warning for this with neither 3.10 nor 3.11 kernel version; but > > patch is correct, and here is my > > Signed-off-by: Vladimir Kondratiev <qca_vkondrat@xxxxxxxxxxxxxxxx> > > If you agree with a patch you don't say you Sign-off-by it as well, > you say Acked-by. The Signed-off-by tag has a very specific meaning > from development to a maintainer's hands, and its definition is on > the Developer Certificate or Origin. > > So in this case Acked-by is better. > > Luis <drop most of CC> I thought that I need to add Signed-off-by: as driver's maintainer, because (quote Documentation/SubmittingPatches): --- The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path. --- This is similar to other maintainers adding its Signed-off-by:. Or, is driver's maintainer an exception from the rule quoted above? Thanks, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html