Search Linux Wireless

Re: [ath5k-devel] [PATCH 1/1] ath5k: Cleanup after API changes patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/02/2008 10:39 PM, Luis R. Rodriguez wrote:
On Feb 2, 2008 4:35 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxxxxxxxxxxx> wrote:
On Feb 1, 2008 10:46 AM, Jiri Slaby <jirislaby@xxxxxxxxx> wrote:
On 02/01/2008 02:25 AM, Luis R. Rodriguez wrote:
@@ -889,13 +900,15 @@ ath5k_copy_channels(struct ath5k_hw *ah,
              /* Write channel info and increment counter */
              channels[count].center_freq = freq;

-             if((mode == AR5K_MODE_11A) ||
-             (mode == AR5K_MODE_11G)){
-                     channels[count].hw_value = chfreq|CHANNEL_OFDM;
-             } else if((mode == AR5K_MODE_11A_TURBO) ||
-             (mode == AR5K_MODE_11G_TURBO)){
-                     channels[count].hw_value = chfreq|CHANNEL_OFDM|CHANNEL_TURBO;
-             }if(mode == AR5K_MODE_11B) {
+             if ((mode == AR5K_MODE_11A) ||
+                     (mode == AR5K_MODE_11G)) {
+                     channels[count].hw_value =
+                             chfreq | CHANNEL_OFDM;
+             } else if ((mode == AR5K_MODE_11A_TURBO) ||
+                     (mode == AR5K_MODE_11G_TURBO)) {
+                     channels[count].hw_value =
+                             chfreq | CHANNEL_OFDM|CHANNEL_TURBO;
+             } if (mode == AR5K_MODE_11B) {
'else' or '\n' before the if, please
Good catch, that should have been an "else if" there. Will repost all
pending patches in a series addressing all posted comments.

Going to move this to a switch, its much more legible.

There was switch IIRC, I think either sparse or -W don't like it too much (enum <-> int)? Please could you check? (-W doesn't bother us.)
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux