On Feb 2, 2008 4:35 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxxxxxxxxxxx> wrote:
>
> On Feb 1, 2008 10:46 AM, Jiri Slaby <jirislaby@xxxxxxxxx> wrote:
> > On 02/01/2008 02:25 AM, Luis R. Rodriguez wrote:
> > > Cleanup after API changes patch (checkpatch.pl stuff) and on
> > > ath5k_hw_rf5112_channel() make use of the new channel->band and
> > > existing ath5k_channel_ok() instead of re-implementing the checks
> > > again. This was necessary to make the code cleaner and fit
> > > the 80-chars wide limit so sending it within the same patch.
> > >
> > > Finally make a note that we should eventually move cap_range stuff
> > > to struct wiphy.
> > >
> > > This patch applies ontop of Nick's API changes patch.
> > >
> > > Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxxxxxxxxxx>
> > >
> > > drivers/net/wireless/ath5k/ath5k.h: Changes-licensed-under: ISC
> > > drivers/net/wireless/ath5k/base.c: Changes-licensed-under: 3-Clause-BSD
> > > drivers/net/wireless/ath5k/initvals.c: Changes-licensed-under: ISC
> > > drivers/net/wireless/ath5k/phy.c: Changes-licensed-under: ISC
> > > ---
> > > drivers/net/wireless/ath5k/ath5k.h | 8 ++-
> > > drivers/net/wireless/ath5k/base.c | 126 +++++++++++++++++++--------------
> > > drivers/net/wireless/ath5k/initvals.c | 6 +-
> > > drivers/net/wireless/ath5k/phy.c | 48 +++++++++----
> > > 4 files changed, 118 insertions(+), 70 deletions(-)
> > >
> > [...]
> > > diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
> > > index 8ddac36..bd9c9a8 100644
> > > --- a/drivers/net/wireless/ath5k/base.c
> > > +++ b/drivers/net/wireless/ath5k/base.c
> > [...]
> > > @@ -889,13 +900,15 @@ ath5k_copy_channels(struct ath5k_hw *ah,
> > > /* Write channel info and increment counter */
> > > channels[count].center_freq = freq;
> > >
> > > - if((mode == AR5K_MODE_11A) ||
> > > - (mode == AR5K_MODE_11G)){
> > > - channels[count].hw_value = chfreq|CHANNEL_OFDM;
> > > - } else if((mode == AR5K_MODE_11A_TURBO) ||
> > > - (mode == AR5K_MODE_11G_TURBO)){
> > > - channels[count].hw_value = chfreq|CHANNEL_OFDM|CHANNEL_TURBO;
> > > - }if(mode == AR5K_MODE_11B) {
> > > + if ((mode == AR5K_MODE_11A) ||
> > > + (mode == AR5K_MODE_11G)) {
> > > + channels[count].hw_value =
> > > + chfreq | CHANNEL_OFDM;
> > > + } else if ((mode == AR5K_MODE_11A_TURBO) ||
> > > + (mode == AR5K_MODE_11G_TURBO)) {
> > > + channels[count].hw_value =
> > > + chfreq | CHANNEL_OFDM|CHANNEL_TURBO;
> > > + } if (mode == AR5K_MODE_11B) {
> >
> > 'else' or '\n' before the if, please
>
> Good catch, that should have been an "else if" there. Will repost all
> pending patches in a series addressing all posted comments.
Going to move this to a switch, its much more legible.
Luis
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
