Solomon Peachy <pizza@xxxxxxxxxxxx> writes: > On Tue, Jun 04, 2013 at 06:09:55AM -0700, Dan Carpenter wrote: >> The patch a910e4a94f69: "cw1200: add driver for the ST-E CW1100 & >> CW1200 WLAN chipsets" from May 24, 2013, has poor input validation >> so the user could write to arbitrary memory. > >> Also I think this API looks like things which should be done with >> normal ioctls. This driver only lets you load the firmware using a >> very ugly custom debugfs interface? > > No, this is a debugging interface designed to interact with the > vendor-supplied testing tool and the passthrough API it requires. The > vendor tool controls the device init sequence, including special > engineering firmware. > > Support for the ETF hooks is optional, and even if compiled in has to be > explicitly enabled with a module parameter. > [...] > > I'll try to robustify this rather ugly interface as much as possible. We have nl80211 testmode interface for just stuff like this. I recommend using that instead of debugfs. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
