Search Linux Wireless

Re: [PATCH 1/2] cfg80211: Userspace may inform kernel of mesh auth method.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Colleen,

>  	if (setup->is_secure)
>  		setup->user_mpm = true;
>  
> +	if (tb[NL80211_MESH_SETUP_AUTH_PROTOCOL]) {
> +		if (!setup->is_authenticated || !setup->is_secure)
> +			return -EINVAL;

Is that really what you want? It seems strange to first check is secured
or authenticated and then allow to set the auth protocol to none, but
that may be fine since I don't really understand the mesh protocol very
well.

However if userspace is in control it can basically do whatever it
likes, so shouldn't you just check "setup->user_mpm"? Or am I
misunderstanding this, and the authentication isn't related to peering
at all?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux