On Tue, 2013-04-23 at 15:06 -0700, Ben Greear wrote: > > This idea suddenly looks a lot more interesting. The ieee80211_tx_status method needs > > to find the remote station & sdata, but in the AP case, the station hash works best, > > and in my many-sta-vif case, the VIF hash works best. I don't see any way to guess > > which hash to use in this case. Indeed, that'd be tricky. > > But, if we first hashed to find sdata, and then had a vif hash in the sdata > > object, the lookup should be fast for cases where the hash function works > > well. > > > > I'll give this a try... > > Seems to mostly be working, but I've a few questions. > > First, if we are hashing sdata on sdata->vif.addr, then we must > assume that everything in that hash has a unique MAC. I'm > thinking that I would just never put monitor devices in > the hash. Is there anything else that would cause problems > with this? Monitor interfaces won't have stations, so they're not needed anyway. > Second, the sta_info_get_bss call is found fairly often. It > talks about finding a station on sdata or associated vlan. > Does this indicate that the there are VLAN sdata objects > with duplicate MACs? Yes. See net/mac80211/iface.c identical_mac_addr_allowed(). > I was hoping I could replace at least most calls to sta_info_get_bss > with one that just searched the new sdata->sta_hash hash table... I have no idea how my answer affects this :) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
