On 04/23/2013 12:42 PM, Ben Greear wrote:
On 04/11/2013 02:19 AM, Johannes Berg wrote:
Another question: Have you thought about hashing the virtual interfaces instead of the stations, and then hashing the stations inside each virtual interface? That would make it a bit of a two-level thing: A1 (in the frame) -> virtual interface A2 (frame) -> station But it would address the TX side efficiently without "some_sta" since you know the virtual interface there already, and could potentially have less impact on the code? On TX it'd actually even be more efficient if you have more than 1 station per interface (right now you don't though)This idea suddenly looks a lot more interesting. The ieee80211_tx_status method needs to find the remote station & sdata, but in the AP case, the station hash works best, and in my many-sta-vif case, the VIF hash works best. I don't see any way to guess which hash to use in this case. But, if we first hashed to find sdata, and then had a vif hash in the sdata object, the lookup should be fast for cases where the hash function works well. I'll give this a try...
Seems to mostly be working, but I've a few questions. First, if we are hashing sdata on sdata->vif.addr, then we must assume that everything in that hash has a unique MAC. I'm thinking that I would just never put monitor devices in the hash. Is there anything else that would cause problems with this? Second, the sta_info_get_bss call is found fairly often. It talks about finding a station on sdata or associated vlan. Does this indicate that the there are VLAN sdata objects with duplicate MACs? I was hoping I could replace at least most calls to sta_info_get_bss with one that just searched the new sdata->sta_hash hash table... Thanks, Ben -- Ben Greear <greearb@xxxxxxxxxxxxxxx> Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
