On Thu, 2013-03-07 at 16:10 +0200, Vladimir Kondratiev wrote: > > > + msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); > > > + if (!msg) > > > + return -ENOMEM; > > > + > > > + hdr = nl80211hdr_put(msg, info->snd_portid, info->snd_seq, 0, > > > + NL80211_CMD_START_P2P_FIND); > > > > Err? What's the value of sending a reply back here? It would seem maybe > > appropriate to send one when it *actually* started, but you haven't > > implemented that. > > > > > + hdr = nl80211hdr_put(msg, info->snd_portid, info->snd_seq, 0, > > > + NL80211_CMD_STOP_P2P_FIND); > > > > same here ... > Yes, agree. I'll add indications, like ROC do. Is there really much value in indications, rather than having it start right away? Similarly, in particular if sending probe responses is offloaded, is there really any reason for userspace to care? OTOH, we also send an indication when a scan starts, so maybe it's useful that way. Just seems that the code requesting this would assume that if it didn't get an error, it will be started, and not really care about when it *really* started operating. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
