> Allow to implement P2P find phase in the driver/firmware. > > Offload scheme designed as follows: > > - Driver provide methods start_p2p_find and stop_p2p_find in the cfg80211_ops; > indicates support for p2p find offload by setting feature > NL80211_FEATURE_P2P_FIND_OFFLOAD Why not just indicate the command presence rather than a feature flag? > - perform legacy scan, through driver's cfg80211_ops 'scan' method Why the legacy scan? btw this is what I was worried about -- this API robs us of the ability to do "progressive" p2p scan. > - configure rx management filter to get probe-request and probe-response frames Interesting, so this is pretty much bypassing the scan BSS table mechanism. I guess it makes sense though. > - driver start p2p find with hardware and notify wpa_supplicant with > cfg80211_p2p_find_notify(NL80211_CMD_START_P2P_FIND) See other mail -- is that really useful? > cfg80211_p2p_find_notify(NL80211_CMD_STOP_P2P_FIND) btw, if both are needed I'd prefer not to give a command number here, it's useless to give anything else and this is a bit confusing. > /** > + * struct cfg80211_p2p_find_params - parameters for P2P find > + * @probe_ie: IE's for probe frames probe request, presumably? Also, this is probably *additional* IEs, i.e. supported rates etc. are expected to be created by the driver? > + * @probe_resp_ie: IE's for probe response frames similarly here? > + * @probe_resp_ie_len: length, bytes, of @probe_resp_ie > + * @min_discoverable_interval and need : otherwise it's not valid kernel-doc > + * @NL80211_ATTR_MIN_DISCOVERABLE_INTERVAL, same here > + genlmsg_multicast_netns(wiphy_net(&rdev->wiphy), msg, 0, > + nl80211_scan_mcgrp.id, GFP_KERNEL); indentation > +static inline int rdev_start_p2p_find(struct cfg80211_registered_device *rdev, > + struct wireless_dev *wdev, > + struct cfg80211_p2p_find_params *params) indentation > +static inline void rdev_stop_p2p_find(struct cfg80211_registered_device *rdev, > + struct wireless_dev *wdev) ditto > + TP_PROTO(struct wiphy *wiphy, struct wireless_dev *wdev, > + struct cfg80211_p2p_find_params *params), ditto > + TP_printk(WDEV_PR_FMT ", cmd: %d", WDEV_PR_ARG, > + __entry->cmd) ditto johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
