> > I think that needs a check "&& ssid_len" or something. Someone's bound > > to try making an IBSS with a hidden SSID and we really don't want that > > to work. > > why? i know, hidden SSIDs are pretty useless but if somedody wants them... why > would you want to make extra effort so it does not work? Uh, I think you should rethink your question. Consider two different hidden-SSID IBSSes. > > > + printk(KERN_DEBUG "%s: beacon TSF higher than local TSF" > > > + " -> IBSS merge with BSSID %s\n", > > > + dev->name, print_mac(mac, mgmt->bssid)); > > > > No way. At the very least you need to ratelimit this. > > well, it should not happen very often, and for debugging i would like to see > this case. would Well, "should" is pretty soft. It can also be trivially triggered as a DOS attack by sending beacons with fake timestamps. > > if (CONFIG_MAC80211_IBSS_DEBUG || net_ratelimit()) > printk(KERN_DEBUG "%s: beacon TSF higher than " > > be ok with you? Maybe && would be better? johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
