Search Linux Wireless

Re: [PATCH v2 3/3] mac80211/minstrel_ht: add support for using CCK rates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Applied patches 1 and 2 but this one had too many smatch complaints:


> #define CCK_GROUP                                       \
>         {                                               \
>                 .streams = 0,                           \
>                 .duration = {                           \
>                         CCK_DURATION_LIST(false),       \
>                         CCK_DURATION_LIST(true)         \
>                 }                                       \
>         }

This seems to have caused smatch to complain, because after having 

#define MCS_GROUP(_streams, _sgi, _ht40)                                \
        [GROUP_IDX(_streams, _sgi, _ht40)] = {                          \

it couldn't prove that the CCK went into slot 12. Are you sure they go
there for sure, with the different initialization?

> +struct minstrel_rate_stats *
> +minstrel_ht_get_stats(struct minstrel_priv *mp, struct minstrel_ht_sta *mi,
> +		      struct ieee80211_tx_rate *rate)
> +{
> +	int group, idx;
> +
> +	if (rate->flags & IEEE80211_TX_RC_MCS) {
> +		group = minstrel_ht_get_group_idx(rate);
> +		idx = rate->idx % MCS_GROUP_RATES;
> +	} else {
> +		group = MINSTREL_CCK_GROUP;
> +
> +		for (idx = 0; idx <= ARRAY_SIZE(mp->cck_rates); idx++)

should be < rather than <=?

> +	if (rate->flags & IEEE80211_TX_RC_MCS);
> +		return true;

ho humm ...

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux