On Mon, 2013-02-11 at 15:10 +0100, Felix Fietkau wrote: > On 2013-02-11 2:57 PM, Christian Lamparter wrote: > > On Monday, February 11, 2013 02:36:05 PM Felix Fietkau wrote: > >> When MCS rates start to get bad in 2.4 GHz because of long range or > >> strong interference, CCK rates can be a lot more robust. > >> > >> This patch adds a pseudo MCS group containing CCK rates (long preamble > >> in the lower 4 slots, short preamble in the upper slots). > >> > >> Signed-off-by: Felix Fietkau <nbd@xxxxxxxxxxx> > >> --- > >> static void > >> +minstrel_ht_update_cck(struct minstrel_priv *mp, struct minstrel_ht_sta *mi, > >> + struct ieee80211_supported_band *sband, > >> + struct ieee80211_sta *sta) > >> +{ > >> + int i; > >> + > >> + if (sband->band != IEEE80211_BAND_2GHZ) > >> + return; > >> + > >> + mi->cck_supported = 0; > >> + mi->cck_supported_short = 0; > >> + for (i = 0; i < 4; i++) { > >> + if (!rate_supported(sta, sband->band, mp->cck_rates[i])) > >> + continue; > > > > Don't we need to check if the receiver (and the minstrel_ht sender) > > supports IEEE80211_HT_CAP_DSSSCCK40 when the phy is in HT40+/- mode? > I don't think this should be handled in the rate control modules, when > mac80211 can easily handle that through the supported rates set (which > seems to be the intention behind this flag in the standard as well). Patches welcome. This corner of the spec doesn't seem to be implemented at all :) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html