Search Linux Wireless

Re: [PATCH] rtlwifi: Initialize rate_init member of struct rate_control_ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/11/2013 03:42 PM, Johannes Berg wrote:
On Mon, 2013-02-11 at 15:37 -0600, Larry Finger wrote:

+	.rate_init = rtl_rate_init,
   	.tx_status = rtl_tx_status,
   	.get_rate = rtl_get_rate,
   };

Shouldn't rate_control_rate_init() in net/mac80211/rate.h be changed to protect
against the oops? I don't see any value in the client driver having to provide a
dummy routine. The rtlwifi family of drivers use their own rate-control
mechanism, and get no rate-control info from mac80211.

In this case, I see no value in them providing rate control operations
at all, and they could just set IEEE80211_HW_HAS_RATE_CONTROL, no?

I think that makes sense.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux