On Mon, Jan 28, 2013 at 4:10 PM, Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote: > On Mon, Jan 28, 2013 at 3:22 PM, Kalle Valo <kvalo@xxxxxxxxxx> wrote: >> Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: >> >>> Question for the list ... >>> >>> Internally, we've identified patches to this new driver as >>> >>> "iwlwifi (MVM):" >>> >>> rather than just "iwlwifi:" >>> >>> We can continue doing so (and would probably also tag patches with >>> "iwlwifi" for core and "iwlwifi (DVM)" for the DVM part. >>> >>> Would "iwlmvm"/"iwldvm"/"iwlwifi" make more sense as that's the module >>> names? It's harder to filter though, I guess. >> >> I would use this: >> >> "iwlwifi: mvm: fix foo" >> > > If two-items notation then "item1: item2: Subject" is better than the > commata notation "iwlwifi, mwm: Fix foo" should simply die... > > More Like-it (mostly seen in media): > > [subtree|driver-family|etc.] special-driver|script|etc: Subject > > For example: > > "[kbuild] deb-pkg: Bump year in copyright > > (kbuild subtree and debbuild script (aka make deb-pkg). > > And yes, I like capital letter in the first word of subject (after ":"). > > Two items is OK. > But more items seen for rtlwifi sth. like "rtlwifi: rtlX: rtlY: rtlZ: > Here now what I wanted to fix" is IMHO bad for extracting patches with > git. > > BTW, why do you need two items? > Is there somewhere a mvm driver in another subtree? > Or new buzz-word: What about "iwlmvm"? > iwlegacy - iwlwifi - iwlmvm... > Better than buzz-words and personal likes/dislikes is the quality of the patches, the embedded (descriptive) text in changelog and a well documented source-code. Worth reading on this topic: "On commit messages" from Peter Hutterer's blog (Linux Xorg hacker). - Sedat - [1] http://who-t.blogspot.de/2009/12/on-commit-messages.html > - Sedat - > >> I don't remember where I saw that style first but I liked it. >> >> -- >> Kalle Valo >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
