Xose, Sent from my iPad On 22 jan. 2013, at 22:12, Xose Vazquez Perez <xose.vazquez@xxxxxxxxx> wrote: > On 01/22/2013 07:58 PM, Gertjan van Wingerde wrote: > >> On 22 jan. 2013, at 17:49, Stanislaw Gruszka <stf_xl@xxxxx> wrote: >> >>> Signed-off-by: Stanislaw Gruszka <stf_xl@xxxxx> >>> Tested-by: Xose Vazquez Perez <xose.vazquez@xxxxxxxxx> >>> --- >>> drivers/net/wireless/rt2x00/rt2x00.h | 2 +- >>> drivers/net/wireless/rt2x00/rt2x00mac.c | 6 +++--- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h >>> index 3e37c19..bef449c 100644 >>> --- a/drivers/net/wireless/rt2x00/rt2x00.h >>> +++ b/drivers/net/wireless/rt2x00/rt2x00.h >>> @@ -92,7 +92,7 @@ >>> #define NOTICE(__dev, __msg, __args...) \ >>> DEBUG_PRINTK(__dev, KERN_NOTICE, "Notice", __msg, ##__args) >>> #define INFO(__dev, __msg, __args...) \ >>> - DEBUG_PRINTK(__dev, KERN_INFO, "Info", __msg, ##__args) >>> + DEBUG_PRINTK_MSG(__dev, KERN_INFO, "Info", __msg, ##__args) >>> #define DEBUG(__dev, __msg, __args...) \ >>> DEBUG_PRINTK(__dev, KERN_DEBUG, "Debug", __msg, ##__args) >>> #define EEPROM(__dev, __msg, __args...) \ > >> I think this change is good, but we should also change WARNING and >> NOTICE. Otherwise they won't be displayed if CONFIG_RT2X00_DEBUG is >> disabled, but INFO will, which would be strange. > > I believe this patch is so useful and trivial enough to be included, > as is, in the next 3.8-rc . > > The next steps can be done for 3.9 To be honest, I wouldn't classify this as a bug, so 3.8-rc is out of the question. And doing a respin to add the other log levels can easily be done rather quickly, so there's no need to split it up. --- Gertjan-- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
