Search Linux Wireless

Re: [PATCH] rt2x00: print chip and firmware version by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stanislaw,

Sent from my iPad

On 22 jan. 2013, at 17:49, Stanislaw Gruszka <stf_xl@xxxxx> wrote:

> Signed-off-by: Stanislaw Gruszka <stf_xl@xxxxx>
> Tested-by: Xose Vazquez Perez <xose.vazquez@xxxxxxxxx>
> ---
> drivers/net/wireless/rt2x00/rt2x00.h    |    2 +-
> drivers/net/wireless/rt2x00/rt2x00mac.c |    6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h
> index 3e37c19..bef449c 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00.h
> +++ b/drivers/net/wireless/rt2x00/rt2x00.h
> @@ -92,7 +92,7 @@
> #define NOTICE(__dev, __msg, __args...) \
>    DEBUG_PRINTK(__dev, KERN_NOTICE, "Notice", __msg, ##__args)
> #define INFO(__dev, __msg, __args...) \
> -    DEBUG_PRINTK(__dev, KERN_INFO, "Info", __msg, ##__args)
> +    DEBUG_PRINTK_MSG(__dev, KERN_INFO, "Info", __msg, ##__args)
> #define DEBUG(__dev, __msg, __args...) \
>    DEBUG_PRINTK(__dev, KERN_DEBUG, "Debug", __msg, ##__args)
> #define EEPROM(__dev, __msg, __args...) \

I think this change is good, but we should also change WARNING and NOTICE. Otherwise they won't be displayed if CONFIG_RT2X00_DEBUG is disabled, but INFO will, which would be strange.

> diff --git a/drivers/net/wireless/rt2x00/rt2x00mac.c b/drivers/net/wireless/rt2x00/rt2x00mac.c
> index ed7a1bb..20c6ecc 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00mac.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00mac.c
> @@ -731,9 +731,9 @@ int rt2x00mac_conf_tx(struct ieee80211_hw *hw,
>    queue->aifs = params->aifs;
>    queue->txop = params->txop;
> 
> -    INFO(rt2x00dev,
> -         "Configured TX queue %d - CWmin: %d, CWmax: %d, Aifs: %d, TXop: %d.\n",
> -         queue_idx, queue->cw_min, queue->cw_max, queue->aifs, queue->txop);
> +    DEBUG(rt2x00dev,
> +          "Configured TX queue %d - CWmin: %d, CWmax: %d, Aifs: %d, TXop: %d.\n",
> +          queue_idx, queue->cw_min, queue->cw_max, queue->aifs, queue->txop);
> 
>    return 0;
> }
> -- 
> 1.7.4.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux