2008/1/16, Chatre, Reinette <reinette.chatre@xxxxxxxxx>:
> On Monday, January 14, 2008 1:43 AM, Joonwoo Park wrote:
>
> > -static inline void iwl_disable_interrupts(struct iwl_priv *priv)
> > +static inline void __iwl_disable_interrupts(struct iwl_priv *priv) {
> > clear_bit(STATUS_INT_ENABLED, &priv->status);
>
> Could the call to iwl_disable_interrupts in iwl_pci_probe be changed to
> __iwl_disable_interrupts? The isr is only activated when the interface
> is brought up so we do not need to do the extra steps (eg.
> synchronize_irq()) during device probe.
>
Hi Reinette,
Thank you for your advice, it seems recent base code's commit inserted
iwl_disable_interrupts() into iwl_pci_probe.
As like you said, for base code __iwl_disable_interrupts() should
better than iwl_disable_interrupts for iwl_pci_probe.
Zhu,
Do you want version of patch for base code?
Can you ACK for this patch?
Thanks,
Joonwoo
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
