On Thursday, January 10, 2008 5:25 PM, Joonwoo Park wrote: > 2008/1/11, Chatre, Reinette <reinette.chatre@xxxxxxxxx>: >> >> Could synchronize_irq() be moved into iwl_disable_interrupts() ? I am > > At this time, iwl_disable_interrupts() can be called with irq > disabled, so for do that I think additional modification would be > needed. If this is the case where iwl_disable_interrupts() is called while in the ISR (where interrupts are disabled), then this behavior may be what we want as synchronize_irq() (as I understand) waits for the handler to complete irrespective of irq enable/disable. What modification are you considering? >> also wondering if we cannot call tasklet_kill() before >> iwl_disable_interrupts() ... thus preventing it from being scheduled >> when we are going down. > > Thanks for your catch, it seems tasklet can re-enable interrupts. > I'll handle and make an another patch for them at this weekend :) Please think it through also as I am exploring with you ... Reinette - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
