Search Linux Wireless

Re: [RFT 3/3] cfg80211: move world roaming check for beacon hints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/13/2012 12:28 PM, Luis R. Rodriguez wrote:
From: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxx>

We should not add new beacon hints even if the wiphy

Maybe 'even' shouldn't be there?

I'll add this series to our kernels for testing...

Thanks,
Ben

is not world roaming. Without this we were always adding
a beacon hint if not world roaming for every non world
roaming wiphy interface.

Reported-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Reported-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxxxxxxxx>
---
  net/wireless/reg.c |    5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index f649b5e..bdc42d9 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -1076,6 +1076,9 @@ static void handle_reg_beacon(struct wiphy *wiphy,

  	chan->beacon_found = true;

+	if (!reg_is_world_roaming(wiphy))
+		return;
+
  	if (wiphy->flags & WIPHY_FLAG_DISABLE_BEACON_HINTS)
  		return;

@@ -1149,8 +1152,6 @@ static void reg_process_beacons(struct wiphy *wiphy)
  	 */
  	if (!last_request)
  		return;
-	if (!reg_is_world_roaming(wiphy))
-		return;
  	wiphy_update_beacon_reg(wiphy);
  }




--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux